Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone gradle plugins #48

Merged
merged 17 commits into from
Oct 22, 2019
Merged

Standalone gradle plugins #48

merged 17 commits into from
Oct 22, 2019

Conversation

iamdanfox
Copy link
Contributor

@iamdanfox iamdanfox commented Oct 22, 2019 •
edited by dansanduleac
Loading

Before this PR

We're spreading logic between baseline and this repo, and don't actually have a particularly simple usage story (we currently tell people to apply com.palantir.baseline-format and add com.palantir.baseline-format.palantir-java-format to their gradle.properties)

After this PR

==COMMIT_MSG==
The standalone com.palantir.java-format plugin provides a formatDiff task. IntelliJ setup has been moved to a com.palantir.java-format-idea plugin.
==COMMIT_MSG==

This should hopefully reduce the coupling between baseline & this repo and make it easier for people to just try out our formatter if they want to.

Possible downsides?

  • this is diverging from spotless slightly, perhaps an alternative would be to get palantirJavaFormat() merged into spotless upstream??

@changelog-app
Copy link

changelog-app bot commented Oct 22, 2019 •
edited by iamdanfox
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

The standalone com.palantir.java-format plugin provides a formatDiff task. IntelliJ setup has been moved to a com.palantir.java-format-idea plugin.

Check the box to generate changelog(s)

  • Generate changelog entry

@dansanduleac
Copy link
Contributor

👍

@bulldozer-bot bulldozer-bot bot merged commit 4cceef8 into develop Oct 22, 2019
@bulldozer-bot bulldozer-bot bot deleted the dfox/standalone-gradle-plugin branch October 22, 2019 16:20
@svc-autorelease
Copy link
Collaborator

Released 0.3.0

@iamdanfox iamdanfox mentioned this pull request Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansanduleac dansanduleac Awaiting requested review from dansanduleac

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamdanfox @dansanduleac @svc-autorelease